Skip to content

Comments

Fix text and image overlap in careers page#6226

Closed
M-DEV-1 wants to merge 12 commits intolayer5io:masterfrom
M-DEV-1:mdev1-responsiveness
Closed

Fix text and image overlap in careers page#6226
M-DEV-1 wants to merge 12 commits intolayer5io:masterfrom
M-DEV-1:mdev1-responsiveness

Conversation

@M-DEV-1
Copy link
Member

@M-DEV-1 M-DEV-1 commented Feb 7, 2025

Description
This PR fixes the text overlap issue in the Open Source Internship section by increasing the margin below the image and adjusting PageHeader spacing to ensure proper separation.

This PR fixes #6225

Before:

After:

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@M-DEV-1 M-DEV-1 changed the title fixes overlapping of images and text Fix text and image overlap in careers page Feb 7, 2025
@l5io
Copy link
Contributor

l5io commented Feb 7, 2025

🚀 Preview for commit f006aac at: https://67a5570f84dbccc837497cb9--layer5.netlify.app

vishalvivekm
vishalvivekm reviewed Feb 8, 2025
View reviewed changes
vishalvivekm
vishalvivekm suggested changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested a minor change

@M-DEV-1
Copy link
Member Author

M-DEV-1 commented Feb 9, 2025

Hi, I'll change it so that it doesn't affect the other sections which uses the component PageHeader

@M-DEV-1 M-DEV-1 requested a review from vishalvivekm February 10, 2025 03:52
@l5io
Copy link
Contributor

l5io commented Feb 10, 2025

🚀 Preview for commit 60af2d8 at: https://67a979bbe489e9d7763f5c3d--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Feb 10, 2025

🚀 Preview for commit 08f7af3 at: https://67a9807fa47afee16d78f4ef--layer5.netlify.app

@vishalvivekm
Copy link
Contributor

vishalvivekm commented Feb 10, 2025

@M-DEV-1
Thank you for your contribution!
Let's discuss this during the website call on Monday at 6:30 PM IST

adding it as an agenda item to the meeting minutes.

@M-DEV-1
Copy link
Member Author

M-DEV-1 commented Feb 10, 2025

@vishalvivekm

Yes, I'll be there!

@leecalcote
Copy link
Member

leecalcote commented Feb 11, 2025

@M-DEV-1, be sure to sign your commits.

@leecalcote leecalcote added the issue/dco Commit sign-off instructions label Feb 11, 2025
@github-actions
Copy link

github-actions bot commented Feb 11, 2025

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.

        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

1 similar comment
@github-actions
Copy link

github-actions bot commented Feb 11, 2025

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.

        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@M-DEV-1
Copy link
Member Author

M-DEV-1 commented Feb 13, 2025

@M-DEV-1, be sure to sign your commits.

I apologize for my mistake, I'll make sure to not miss sign offs from now on.

@l5io
Copy link
Contributor

l5io commented Feb 13, 2025

🚀 Preview for commit a5bd2ba at: https://67ae7ece3a1af049852c182c--layer5.netlify.app

@M-DEV-1
Copy link
Member Author

M-DEV-1 commented Feb 13, 2025

I had turned on the --signoff settings for my IDE as well as my .gitconfig to ensure that no signoffs are missed. I'm not sure why the DCO check is still failing.

M-DEV-1 and others added 11 commits February 14, 2025 09:10
@M-DEV-1
fix overlapping | add margin
dc256ce 
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@M-DEV-1
fix: remove unintended code affecting PageHeader component
054dc27 
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@M-DEV-1
fix: improve padding on careers page
ea15926 
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@vishalvivekm @M-DEV-1
gsoc-2025-ideas
9004367 
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@vishalvivekm @M-DEV-1
lfx-2025-term-1
d02820c 
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@vishalvivekm @M-DEV-1
Update src/collections/programs/gsoc-2025/index.mdx
6549b7a 
Signed-off-by: Vivek Vishal <vishalvivek488@gmail.com>
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@vishalvivekm @M-DEV-1
Fix participate button in gsoc
98a54d8 
Signed-off-by: Vivek Vishal <vishalvivek488@gmail.com>
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@vishalvivekm @M-DEV-1
Fix button in lfx
9cb7801 
Signed-off-by: Vivek Vishal <vishalvivek488@gmail.com>
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@vishalvivekm @M-DEV-1
update gsoc 2025 program
d8d8472 
Signed-off-by: Vivek Vishal <vishalvivek488@gmail.com>
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@vishalvivekm @M-DEV-1
Apply suggestions from code review
d7ea69e 
Signed-off-by: Vivek Vishal <vishalvivek488@gmail.com>
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@vishalvivekm @M-DEV-1
update year
6dd41c7 
Signed-off-by: Vivek Vishal <vishalvivek488@gmail.com>
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@vishalvivekm @M-DEV-1
Update src/collections/programs/gsoc-2025/index.mdx
a2003b2 
Signed-off-by: Vivek Vishal <vishalvivek488@gmail.com>
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@M-DEV-1 M-DEV-1 force-pushed the mdev1-responsiveness branch from a5bd2ba to a2003b2 Compare February 14, 2025 03:40
@M-DEV-1 M-DEV-1 closed this Feb 14, 2025
@M-DEV-1 M-DEV-1 deleted the mdev1-responsiveness branch February 14, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vishalvivekm vishalvivekm Awaiting requested review from vishalvivekm

Assignees

No one assigned

Labels

area/careers issue/dco Commit sign-off instructions project/meshery

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Responsiveness Issue on Careers Page

4 participants

@M-DEV-1 @l5io @vishalvivekm @leecalcote